-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stream buffing an MCA option again #10746
Conversation
* Way back when the stream buffering option was introduced it was an MCA: open-mpi@4dd9f89a9 - It changed to a CLI option at some point. * Make this an MCA option once again, and connect it with the PRRTE CLI options. Signed-off-by: Joshua Hursey <[email protected]>
Pairs with: openpmix/prrte#1489 |
Isn't that going to break |
I think you may run into issues here - but it's totally up to you over here. I'm not yet convinced of the piece over in PRRTE, but that's another matter. |
@rhc54 I'm not sure I understand your concern. The application (whether in OMPI or their code) can call I did test this with a few different scenarios, and it works fine. |
I'm half blind on painkillers, so my brain is mush - please let things percolate down slowly thru the mud. I agree about the app always being able to do this. Just trying to get my head around the overall IO path and what we want to happen, and what they expect to see. |
@rhc54 hope you feel better soon. Is there a test we can add to ensure proper streaming behavior for both mpirun and prterun? I've been trying to read manpages, but didn't fine a way to query that from a file descriptor. |
I think Josh and I are discussing whether mpirun needs to have a particular behavior or not over on the PRRTE side. |
FYI: We resolved the issue on the PRRTE side (openpmix/prrte#1489) so this PR is ready to go. |
it was an MCA: 4dd9f89a9
PRRTE CLI options.